Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tsconfig): support tsconfig.json files with comments #826

Merged
merged 1 commit into from Sep 11, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/parser/tsconfig.js
@@ -1,10 +1,12 @@
const requirePackageName = require('require-package-name');
const { readFileSync } = require('fs');
const JSON5 = require('json5');

export default function tsconfigParser(filePath, deps) {
const content = readFileSync(filePath, { encoding: 'utf8' });
const foundDeps = [];
const tsconfigJson = JSON.parse(content);
// Typescript uses 'jsonc-parser' to parse tsconfig.json, but json5 is a superset of jsonc syntax (JSON + js comments)
const tsconfigJson = JSON5.parse(content);
const types = tsconfigJson.compilerOptions?.types;
if (types) {
types.forEach((pkg) => {
Expand Down