Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --quiet flag to suppress No depcheck issue messages #829

Merged
merged 1 commit into from Aug 24, 2023

Conversation

openam
Copy link
Contributor

@openam openam commented Aug 24, 2023

Closes #759

@rumpl
Copy link
Member

rumpl commented Aug 24, 2023

In my mind a --quiet would make depcheck not print anything at all, could we update it so that --quiet doesn't print anything?

@openam
Copy link
Contributor Author

openam commented Aug 24, 2023

@rumpl That sounds more like a --silent tag. The point of this PR was to make it so that people using a monorepo wouldn't have to look through 100 lines of No depcheck issue noise to find the one line that has an error. e.g.

many more
...
constants: No depcheck issue
permissions: No depcheck issue
utils: No depcheck issue
errors: No depcheck issue
logger: No depcheck issue
aws-sqs: No depcheck issue
aws-s3: No depcheck issue
koa-logger: No depcheck issue
opsgenie: No depcheck issue
config: Missing dependencies
config: * logger: ./index.js
geo: No depcheck issue
proxy: No depcheck issue
ably: No depcheck issue
dashboard: No depcheck issue
authenticator: No depcheck issue
...
plus many more
...
lerna ERR! Received non-zero exit code 255 during execution
lerna success exec Executed command in 108 packages: "depcheck"

vs

config: Missing dependencies
config: * logger: ./index.js
lerna ERR! Received non-zero exit code 255 during execution
lerna success exec Executed command in 108 packages: "depcheck --quiet"

@seansfkelley
Copy link
Contributor

Throwing my hat in the ring here as a commenter on the original issue: I agree on the distinction between --quiet and --silent (though can't really imagine when I would want to use the latter with a tool like depcheck). When I give --quiet to some arbitrary tool, I typically expect only "essential" output to be printed (or: output requiring an action from me). Maybe there is more non-essential logging that should be covered by --quiet than just this line, but I definitely do want to see in which file the issues were found.

@rumpl
Copy link
Member

rumpl commented Aug 24, 2023

Great, thanks for this!

@rumpl rumpl merged commit 3ae0c5e into depcheck:main Aug 24, 2023
3 checks passed
@openam openam deleted the quiet-flag branch August 29, 2023 15:35
@openam
Copy link
Contributor Author

openam commented Aug 29, 2023

@rumpl Is there anything I need to do to get a version released that contains this change? Unfortunately this was merged in like 3 days after the last release.

@rumpl
Copy link
Member

rumpl commented Aug 29, 2023

You only need to ask, I'll make a new release tomorrow ;)

@openam
Copy link
Contributor Author

openam commented Sep 1, 2023

@rumpl would you please make a release with this --quiet flag.

@rumpl
Copy link
Member

rumpl commented Sep 11, 2023

@openam Version 1.4.6 with this option was just released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag to make logs readable and less verbose
3 participants