Implement missing dependencies feature #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename "no unused dependencies" to "no depcheck issue" - Lowercase the "Dependencies" - Remove the blank line between each output section.
- E2E test case - Unit test - CLI test
- Filter built-in modules as missing dependencies. - Known bug: dependencies from nested project is marked as missing.
Current coverage is
|
- Those folder treats as another module and check by itself. - Update the check-json build script. - Add missing dependencies check in check-json build script.
lijunle
added a commit
that referenced
this pull request
Jan 17, 2016
Implement missing dependencies feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #41 #83
Known bug: dependencies from nested folder project is marked as missing.(See breaking change)package.jsonfile. Such folder is considered as another module and should set up with another depcheck.