New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using @dependabot recreate
doesn't do anything
#1645
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Well, that's one way to deal with reported issues. I understand you're just a bot, but wouldn't it make sense if a human looked at it? ;-) |
Having the same issue, dependabot temporarily changes the description to let me know that it's rebasing the PR but nothing about the PR is touched or changed, and I didn't request a rebase in the first place. |
I had the same problem in https://github.com/xh3b4sd/logger/pull/10. After a couple of minutes I got impatient and moved on. Dependabot is pretty slow at times and I am not sure what it is doing and for how long I am supposed to wait for anything to happen. Note that in the linked PR no actions seem to have been run at all in the last commit so it might be related to Github Actions as well. |
@mthmulders in your case it seems like the PR was created, but then we encountered an issue adding labels, previously Dependabot would "lose" those pull requests, and so the @amiralibazazi what you're describing sounds like Dependabot is rebasing those PRs because the main branch was changed, Dependabot will rebase PRs if one of the manifest files or lockfiles was changed (a Gemfile or package.json for example). @xh3b4sd it seems like Dependabot did 👍 on your comment, you may have merged the PR before the rebase was able to complete? Also I noticed that you're running an action that commits back to the branch, normally dependabot will no longer be able to rebase those PRs, if you're OK with Dependabot force pushing over the commits, you may want to configure your action to commit with |
Thanks for reaching out, @jurre.
I've sent a |
Unfortunately we won't be able to re-register these old PRs, Dependabot simply doesn't know about them and we can't handle any comments on these PRs, what I meant to say is that it has been fixed for future PRs. However, I just spotted that you're on |
Thanks for noticing, I didn't know I had to trigger migration manually. |
I never know when dependabot will still do something or not or how long it will take. Knowing that dependabot will not do anything after another commit is good, though why is it reacting then with thumbs up. The user feedback so far suggests that it will do something, but it did not do anything. Further I would not like to encode third party dependency semantics in commit messages. If everyone would do that it would become impossible to integrate systems properly. Regardless, getting back with your feedback is appreciated. |
I understand. It's not deterministic so it's hard to answer, but we can think about ways to improve the experience, I appreciate your feedback 👍 Looking at the PR description history it does seem like dependabot started to rebase the PR:
But then the PR was merged about 9 minutes later. It can definitely take more than 9 minutes to rebase, as we actually trigger a new update on top of the new ref. When that notice is being shown, Dependabot is still busy performing work.
It won't rebase, but it will recreate, that's why it's giving a thumbs-up here.
That's fine, you don't have to. It's just that dependabot can't know if it's ok to rebase the commit if the main branch has changed if you don't specify that, so it won't keep the PR up to date automatically. |
I think this issue has since been resolved |
Negative. In what was has it been resolved @jurre ? Still happening as of now. Asked to |
Happening to me as well... |
I just experienced the same issue. |
Yeah seems to be happening still 😕 |
1 similar comment
Yeah seems to be happening still 😕 |
Three days, three recreate's, nothing happening. |
I am not getting any response from No thumbs up, no response |
Having this issue too on private packages.
I need to recreate the PR and not rebase it, cause it must re-do the "update" otherwise it will generate a conflict. |
This is now becoming a catch-all issue. Unfortunately catch-call issues aren't really helpful because while the symptoms may be similar, the root cause may be entirely different. We've fixed a number of bugs related to tracking PR state in the DB, but if for some reason you're still seeing issues, please open a new issue and be sure to include a link to your repo. If it's a private repo, then open a support ticket. Do NOT do a "me too" comment on this issue as it's unlikely to be seen / responded to. |
Hi all,
On my GitHub repository with a fairly simple JavaScript project, I'm using Dependabot.
One of the Pull Requests created by Dependabot has a merge conflict with master, so I thought it would be good to have Dependabot recreate the Pull Request.
I've issued
@dependabot recreate
twice, but nothing happens. The bot doesn't reply with a 👍 , nor is the Pull Request touched in any way.Am I misusing the feature, or does it not work as expected?
The text was updated successfully, but these errors were encountered: