Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid JSON in package.json results in Dependabot closing pull requests #180

Closed
StephanBijzitter opened this issue Dec 18, 2017 · 1 comment

Comments

@StephanBijzitter
Copy link

StephanBijzitter commented Dec 18, 2017

I was foolish enough to commit directly to master and i accidentally typed part of the commit message into package.json. Needless to say, this meant the JSON was invalid. The result: Dependabot closed the one pull request that was still open, stating it detected that the dependency is now up to date and the PR is no longer needed.

So this seems to be a small bug which occurs when it tries to parse invalid JSON. Or, of course, it's completely unrelated and the timing is just coincidental... you never really know.

If you type my github username in your email client you'll find previous conversations which will direct you to our github organisation, the repository in question ends with -Tests and the pull request number is 47. Hopefully you'll be able to pull some data and fix this if it really is caused by invalid JSON.

@StephanBijzitter StephanBijzitter changed the title Invalid JSON in package.json results in Dependabot goofing out Invalid JSON in package.json results in Dependabot closing pull requests Dec 18, 2017
@greysteil
Copy link
Contributor

Definitely a bug! Fixed, and with a regression spec to ensure it can't happen again. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants