Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot pull request linked wrong repository for firebase-admin-python #3171

Closed
zeshuaro opened this issue Feb 20, 2021 · 1 comment
Closed
Labels
F: package-metadata The metadata that Dependabot fetched for the package L: python:pip Python packages via pip T: bug 🐞 Something isn't working

Comments

@zeshuaro
Copy link

Package manager/ecosystem
pip/Python

Manifest contents prior to update
requirements.txt prior to update

Updated dependency
firebase-admin from 4.5.1 to 4.5.2

What you expected to see, versus what you actually saw
The pull request that Dependabot created linked the wrong repository. It linked firebase-admin-go where it should be linking firebase-admin-python. And so the diff tree was also incorrect as it showed the one from firebase-admin-go

Images of the diff or a link to the PR, issue or logs
Here is the link to the PR

@zeshuaro zeshuaro added the T: bug 🐞 Something isn't working label Feb 20, 2021
@zeshuaro zeshuaro changed the title Dependabot pull request linked wrong repository Dependabot pull request linked wrong repository fore firebase-admin-python Feb 20, 2021
@zeshuaro zeshuaro changed the title Dependabot pull request linked wrong repository fore firebase-admin-python Dependabot pull request linked wrong repository for firebase-admin-python Feb 20, 2021
@jeffwidman jeffwidman added L: python:pip Python packages via pip F: package-metadata The metadata that Dependabot fetched for the package labels Nov 23, 2022
@jeffwidman
Copy link
Member

👋 sorry for the slow reply.

Is this still an issue? I suspect it was caused by incorrect metadata published to PyPI... I checked https://github.com/firebase/firebase-admin-python/commits/master/setup.py but didn't see any obvious fixes of a typo pointing at the wrong repo, however firebase/firebase-admin-python#613 added a metadata URL that Dependabot will use.

I'm going to close as I'm pretty confident it's fixed by ☝️ but if for some reason I'm wrong, please comment and we can re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: package-metadata The metadata that Dependabot fetched for the package L: python:pip Python packages via pip T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants