Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git submodules #363

Closed
greysteil opened this issue Apr 27, 2018 · 7 comments
Closed

Git submodules #363

greysteil opened this issue Apr 27, 2018 · 7 comments

Comments

@greysteil
Copy link
Contributor

From @Floppy on May 31, 2017 9:58

Probably a low priority niche use case, but a new "language" for updating git submodule versions would be incredibly useful (at least for me).

I have a number of Jekyll sites that include content from other repositories via submodules: https://github.com/SomethingNewUK/somethingnewuk.github.io/ is probably the most complex of those, with about 4 submodules in various subdirectories.

User story attempt:

As a website maintainer who does silly things with Jekyll
I would like to be able to add a "git submodule" language to a repository
So that I can get an automatic PR created when the submodule's repository has been updated

Copied from original issue: dependabot/feedback#4

@greysteil
Copy link
Contributor Author

From @hmarr on May 31, 2017 10:13

In theory, I'm 👍 - it'd be a nice feature to support, and the implementation shouldn't be too tricky.

We'll update this issue when we have a more concrete plan.

@greysteil
Copy link
Contributor Author

Just added support for these. @Floppy - if you run it on the repo you mentioned you'll get a resolution error, because the branch you specify for _data/popolo-data has been deleted. We could do better on the error message, but it'll do for now :)

🎉

@greysteil
Copy link
Contributor Author

From @Floppy on September 9, 2017 8:42

holy crap - I'm gonna try this right now. :D

@greysteil
Copy link
Contributor Author

From @Floppy on September 11, 2017 9:6

Not sure it's working, unless there's still something wrong on my repo. I've fixed the missing branch (thanks for spotting that!) so I think it should work now on https://github.com/SomethingNewUK/somethingnewuk.github.io.

However, while there are two submodules that need updating (_data/finances and _data/popolo_data) there, no PRs are appearing, whether on an automatic or manual bump.

Any thoughts?

@greysteil
Copy link
Contributor Author

From @Floppy on September 11, 2017 9:8

Ignore me! I just realised I need to add it as another language! I'll report back with results.

@greysteil
Copy link
Contributor Author

From @Floppy on September 11, 2017 9:8

BOOM 💥

It works - I love you guys :D

@greysteil
Copy link
Contributor Author

🎉

@deivid-rodriguez - I saw you got an error bumping submodules. At the moment it can't handle anything other than GitHub ones, but I'll hook it into the git internal transfer protocols this evening and get that fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant