Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict resolution updates can be a bit noisy #365

Closed
greysteil opened this issue Apr 27, 2018 · 2 comments
Closed

Conflict resolution updates can be a bit noisy #365

greysteil opened this issue Apr 27, 2018 · 2 comments

Comments

@greysteil
Copy link
Contributor

From @Floppy on June 1, 2017 10:29

I'm updating a lot of stuff in one go, so this might be irrelevant for most users, but I find the conflict resolution comment to be unnecessarily noisy. Github already warns me that there are conflicts and won't let me merge, and dependabot is usually only a couple of minutes behind, so I'm not sure I really need a comment (lovely and polite though it is). I'm not in a "normal use" mode yet though, more of a "huge numbers of updates" mode, so this might not be a problem normally. Just raising in case others feel the same really. Perhaps an option to enable/disable them?

Copied from original issue: dependabot/feedback#6

@greysteil
Copy link
Contributor Author

I think we could probably get away without that comment - we mention it in the PR description anyway. I'll disable it and keep track of whether people are doing the rebases manually when they could just be waiting for Dependabot.

@greysteil
Copy link
Contributor Author

Resolved! We'll now only comment in for the case where you re-open an old Dependabot pull request that's fallen behind master (which is unlikely to happen in bulk, so shouldn't be noisy).

If we see a lot of people doing rebases themselves manually I'll have another look. One option would be for us to edit the PR description during updating, which avoids sending an email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant