-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updated between original PR and rebase has old commit message and PR title not updated #4821
Comments
Closing due to lack of response. |
It's possible. I can't remember why I found this one worth submitting as new. Maybe because this is about If 4652 is solved I will be very happy to update my reproducer (if necessary) and test it. Thanks for checking. |
Awesome, thanks @pzygielo! |
I observe (not sure - still or again) bad commit message and title not updated:
The commit changes
|
This is still the case. The original change: diff --git a/pom.xml b/pom.xml
index ce7c88da..2f160508 100644
--- a/pom.xml
+++ b/pom.xml
@@ -245,7 +245,7 @@
<dependency>
<groupId>org.htmlunit</groupId>
<artifactId>htmlunit</artifactId>
- <version>3.0.0</version>
+ <version>3.11.0</version>
<scope>test</scope>
</dependency>
<dependency> This update was accompanied by the parallel PR, also dependabot-generated, for security issue to update htmlunit from 3.0.0 to 3.0.9. The update to 3.0.9 was picked first and merged, which caused conflict and triggered auto-rebase of PR for upgrade to 3.11.0. Final diff after auto-rebase: diff --git a/pom.xml b/pom.xml
index b8909a91..2f160508 100644
--- a/pom.xml
+++ b/pom.xml
@@ -245,7 +245,7 @@
<dependency>
<groupId>org.htmlunit</groupId>
<artifactId>htmlunit</artifactId>
- <version>3.9.0</version>
+ <version>3.11.0</version>
<scope>test</scope>
</dependency>
<dependency> Commit message (not updated):
PR title not updated: Bump org.htmlunit:htmlunit from 3.0.0 to 3.11.0 (does not reflect the change) PR description also not updated.
|
Package ecosystem
maven
Manifest location and content prior to update
https://github.com/pzrep/dependabot-commit-message/blob/master/pom.xml
dependabot.yml content
https://github.com/pzrep/dependabot-commit-message/blob/master/.github/dependabot.yml
Updated dependency
net.sf.saxon
:Saxon-HE
:10.6
->11.2
What you expected to see, versus what you actually saw
commit message
Expected:
Actual:
Images of the diff or a link to the PR, issue or logs
https://github.com/pzrep/dependabot-commit-message/pull/1/files
🕹 Bonus points: Smallest manifest that reproduces the issue
https://github.com/pzrep/dependabot-commit-message
This seems related - #4652 (comment)
This is wrong expectation if the dependency under the change was updated in the meantime.
PR title can be updated by repo maintainer, but not the commit message, which sometimes has content based on the version before update (not shown in linked reproducer).
The text was updated successfully, but these errors were encountered: