Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot flip-flop with python_full_version/python_version #6091

Closed
1 task done
glensc opened this issue Nov 9, 2022 · 9 comments
Closed
1 task done

Dependabot flip-flop with python_full_version/python_version #6091

glensc opened this issue Nov 9, 2022 · 9 comments
Labels
L: python:pipenv Python packages via pipenv python Dependabot pull requests that update Python code T: bug 🐞 Something isn't working

Comments

@glensc
Copy link

glensc commented Nov 9, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

pip, pipenv

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

No response

Updated dependency

No response

What you expected to see, versus what you actually saw

It's becoming ridiculous already how dependabot fight with itself changing python_version to python_full_version and vice versa:

....and so on!

and typically the changes are not even for packages that are being bumped.

the same changes are visible in Pipfile.lock in same commits as well.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@glensc glensc added the T: bug 🐞 Something isn't working label Nov 9, 2022
@glensc
Copy link
Author

glensc commented Nov 9, 2022

my guess is that dependabot is running different versions of pipenv or python versions which is causing this.

but pipenv lock hasn't been updated for a while:

I don't know that's the place for the pin that is used to run pip/pipenv updates, but it might be.

@jeffwidman jeffwidman added L: python:pip Python packages via pip python Dependabot pull requests that update Python code labels Nov 9, 2022
@jeffwidman
Copy link
Member

Thanks for the report. This needs fixing, and your description made me 😄 :

ridiculous already how dependabot fight with itself

Not sure of root cause, but your hunch sounds reasonable as a starting place.

@glensc
Copy link
Author

glensc commented Nov 23, 2022

I think you should update pipenv:

at least the problem i reported there did not repeat with 2022.9.24

@deivid-rodriguez
Copy link
Contributor

Yeah, I already start that at #6104, but it's a tricky upgrade so it may take us some time.

@glensc
Copy link
Author

glensc commented Dec 21, 2022

Unbelievable. it also removes version markers now:

because it decided to write:

-            "markers": "python_version <= '3.7'",
+            "index": "pypi",

This is also fixed in newer pipenv or not yet reported?

@glensc
Copy link
Author

glensc commented Jan 14, 2023

Is this the same problem?

Removing attributes may damage distribution, if it drops the version range. see commit where I restored it manually:

@jeffwidman
Copy link
Member

This will hopefully be fixed by:

@jeffwidman jeffwidman linked a pull request Aug 3, 2023 that will close this issue
@deivid-rodriguez
Copy link
Contributor

Can you verify if the recent update of pipenv has fixed thanks? Thanks for all the pipenv reports and patience 🙏.

@deivid-rodriguez
Copy link
Contributor

Assuming this got fixed since we got no further feedback.

@deivid-rodriguez deivid-rodriguez added L: python:pipenv Python packages via pipenv and removed L: python:pip Python packages via pip labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: python:pipenv Python packages via pipenv python Dependabot pull requests that update Python code T: bug 🐞 Something isn't working
Projects
None yet
3 participants