Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Python version not detected if .python-version contains comments #6650

Closed
1 task done
aciba90 opened this issue Feb 13, 2023 · 1 comment · Fixed by #9519
Closed
1 task done

Minimum Python version not detected if .python-version contains comments #6650

aciba90 opened this issue Feb 13, 2023 · 1 comment · Fixed by #9519
Assignees
Labels
Batch How We Work: Feature. Outcome achieved within 1 iteration. Can live under an epic, or stand alone. good first issue L: python:pip Python packages via pip T: bug 🐞 Something isn't working

Comments

@aciba90
Copy link

aciba90 commented Feb 13, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

pip

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

https://github.com/canonical/pycloudlib/blob/b02ba24b214ddf922491ee711b4ffe382c450da7/dev-requirements.txt

dependabot.yml content

https://github.com/canonical/pycloudlib/blob/b02ba24b214ddf922491ee711b4ffe382c450da7/.github/dependabot.yml

Updated dependency

No response

What you expected to see, versus what you actually saw

I expected dependabot to correctly detect the minimum Python version defined in .python-version and issue upgrades with correct python dependencies' versions.

If .python-version contains comments, then the suggested dependecies' versions were always the newest one.

Not working configuration: https://github.com/canonical/pycloudlib/blob/b02ba24b214ddf922491ee711b4ffe382c450da7/

Working configuration: canonical/pycloudlib#275

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

This PR tried to bump flake8 to a version that was not compatible with python 3.6 (defined in .python-version):

canonical/pycloudlib#274

Smallest manifest that reproduces the issue

dependabot.yml:

version: 2
updates:
  - package-ecosystem: "pip"
    directory: "/"

.python-version:

3.6.5
# Specifies the python version that dependabot should use
# Note: The version must specify major.minor.patch components
# and be supported on:
# https://github.com/dependabot/dependabot-core/blob/7822f07e76cab9be6eca86a91aafc8d72bc42536/python/lib/dependabot/python/python_versions.rb
@aciba90 aciba90 added the T: bug 🐞 Something isn't working label Feb 13, 2023
@jeffwidman jeffwidman added L: python:pip Python packages via pip good first issue labels Feb 13, 2023
@abdulapopoola abdulapopoola added the Batch How We Work: Feature. Outcome achieved within 1 iteration. Can live under an epic, or stand alone. label Mar 14, 2024
@mohammadalizabihitari
Copy link
Collaborator

Hi, I am working on this issue, will keep you updated as I progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Batch How We Work: Feature. Outcome achieved within 1 iteration. Can live under an epic, or stand alone. good first issue L: python:pip Python packages via pip T: bug 🐞 Something isn't working
Projects
Archived in project
4 participants