Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot fails to update pnpm-lock.yaml #8186

Open
1 task done
gferreri opened this issue Oct 12, 2023 · 7 comments
Open
1 task done

dependabot fails to update pnpm-lock.yaml #8186

gferreri opened this issue Oct 12, 2023 · 7 comments
Labels
L: javascript:pnpm npm packages via pnpm T: bug 🐞 Something isn't working

Comments

@gferreri
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

pnpm

Package manager version

8.8.0

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

No response

Updated dependency

No response

What you expected to see, versus what you actually saw

Expected postCSS to be updated in pnpm-lock.yaml

Actual: received error message: Dependabot cannot update postcss to a non-vulnerable version

However, running pnpm audit --fix successfully patches the dependency.

truncated logs:

proxy | 2023/10/11 21:26:31 [139] GET https://registry.npmjs.org:443/type-fest
  proxy | 2023/10/11 21:26:31 [140] GET https://registry.npmjs.org:443/caniuse-lite/-/caniuse-lite-1.0.30001547.tgz
  proxy | 2023/10/11 21:26:31 [143] GET https://registry.npmjs.org:443/electron-to-chromium/-/electron-to-chromium-1.4.550.tgz
  proxy | 2023/10/11 21:26:31 [138] 200 https://registry.npmjs.org:443/escalade
  proxy | 2023/10/11 21:26:31 [144] GET https://registry.npmjs.org:443/update-browserslist-db/-/update-browserslist-db-1.0.13.tgz
  proxy | 2023/10/11 21:26:31 [139] 200 https://registry.npmjs.org:443/type-fest
  proxy | 2023/10/11 21:26:31 [140] 200 https://registry.npmjs.org:443/caniuse-lite/-/caniuse-lite-1.0.30001547.tgz
  proxy | 2023/10/11 21:26:31 [143] 200 https://registry.npmjs.org:443/electron-to-chromium/-/electron-to-chromium-1.4.550.tgz
  proxy | 2023/10/11 21:26:31 [144] 200 https://registry.npmjs.org:443/update-browserslist-db/-/update-browserslist-db-1.0.13.tgz
updater | 2023/10/11 21:26:32 INFO <job_734059994> VulnerabilityAuditor: starting audit
updater | 2023/10/11 21:26:32 INFO <job_734059994> VulnerabilityAuditor: missing lockfile
updater | 2023/10/11 21:26:32 INFO <job_734059994> Requirements to unlock update_not_possible
updater | 2023/10/11 21:26:32 INFO <job_734059994> Requirements update strategy bump_versions
updater | 2023/10/11 21:26:33 INFO <job_734059994> The latest possible version of postcss that can be installed is 8.4.29
updater | 2023/10/11 21:26:33 INFO <job_734059994> The earliest fixed version is 8.4.31.
updater | 2023/10/11 21:26:33 INFO <job_734059994> Finished job processing
updater | 2023/10/11 21:26:33 INFO Results:
updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | +------------------------------+
updater | |            Errors            |
updater | +------------------------------+
updater | | security_update_not_possible |
updater | +------------------------------+
updater | time="2023-10-11T21:26:33Z" level=info msg="task complete" container_id=job-734059994-updater exit_code=0 job_id=734059994 step=updater

Native package manager behavior

❯ pnpm audit --fix
1 overrides were added to package.json to fix vulnerabilities.
Run "pnpm install" to apply the fixes.

The added overrides:
{
  "postcss@<8.4.31": ">=8.4.31"
}

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@gferreri gferreri added the T: bug 🐞 Something isn't working label Oct 12, 2023
@Phoenixmatrix
Copy link

Hitting this too. Possibly a problem with pnpm workspaces since the pnpm-lock isn't in the same package as the security issue? (it's one folder up, as per how workspaces work).

@deivid-rodriguez deivid-rodriguez added the L: javascript:pnpm npm packages via pnpm label Nov 10, 2023
@deivid-rodriguez
Copy link
Contributor

Thanks for letting us know. Can any of you share an example repository showing this problem?

@gferreri
Copy link
Author

Here's a minimal example.

@czerwiukk
Copy link

I am encountering a similar issue. My lockfile is not at the top level of the repo (frontend/pnpm-lock.yaml).

updater | 2023/12/18 09:33:03 INFO <job_763337106> VulnerabilityAuditor: starting audit
updater | 2023/12/18 09:33:03 INFO <job_763337106> VulnerabilityAuditor: missing lockfile
updater | 2023/12/18 09:33:03 INFO <job_763337106> Requirements to unlock update_not_possible
updater | 2023/12/18 09:33:03 INFO <job_763337106> Requirements update strategy bump_versions
updater | 2023/12/18 09:33:04 INFO <job_763337106> The latest possible version of @koa/cors that can be installed is 4.0.0
updater | 2023/12/18 09:33:04 INFO <job_763337106> The earliest fixed version is 5.0.0.
updater | 2023/12/18 09:33:04 INFO <job_763337106> Finished job processing
updater | 2023/12/18 09:33:04 INFO Results:
updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | +------------------------------+
updater | |            Errors            |
updater | +------------------------------+
updater | | security_update_not_possible |
updater | +------------------------------+
updater | time="2023-12-18T09:33:04Z" level=info msg="task complete" container_id=job-763337106-updater exit_code=0 job_id=763337106 step=updater

@devonpmack
Copy link

Also running into this issue in our monorepo.

@ardokirsipuu
Copy link

Same issue with also yarn.lock. Monorepo but no workspaces (one package.json, one yarn.lock, one node_modules - all in the root of the repo).

@Apostolos-Daniel
Copy link

We're having the same issue with pnpm and dependabot. Are there any plans to support pnpm-lock.yaml? Our lock file is in the root directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript:pnpm npm packages via pnpm T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants