Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Directory Not Working for Helm Charts #9173

Open
1 task done
jpinz opened this issue Feb 29, 2024 · 4 comments
Open
1 task done

Multi Directory Not Working for Helm Charts #9173

jpinz opened this issue Feb 29, 2024 · 4 comments
Assignees
@jpinz
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR T: bug 🐞 Something isn't working T: feature-request Requests for new features

Comments

@jpinz
Copy link
Collaborator

jpinz commented Feb 29, 2024 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

Docker/Helm

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

Don't want to share too much, but here are the relevant parts, note that it is multi-directory:

security-updates-only: false
grouped-update: true
 updating-a-pull-request: false
 source:
    directory: /
    directories:
    - /src/helmcharts/
    provider: azure
    repo: xxxx
    branch: main
 package-manager: docker

Updated dependency

No response

What you expected to see, versus what you actually saw

Expected everything to work, instead got an error and stacktrace:

Starting job processing
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> No Dockerfile!
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/docker/lib/dependabot/docker/file_parser.rb:103:in 'check_required_files'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/common/lib/dependabot/file_parsers/base.rb:50:in 'initialize'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'bind_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'validate_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in 'block in _on_method_added'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/abstract/declare.rb:38:in 'new'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/abstract/declare.rb:38:in 'block in declare_abstract'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:196:in 'dependency_file_parser'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'bind_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'validate_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in 'block in _on_method_added'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:190:in 'parse_files!'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'bind_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'validate_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in 'block in _on_method_added'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:152:in 'block in initialize'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:150:in 'each'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:150:in 'initialize'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'bind_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'validate_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in 'block in _on_method_added'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:29:in 'new'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:29:in 'create_from_job_definition'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'bind_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in 'validate_call'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in 'block in _on_method_added'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:21:in 'perform_job'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:36:in 'run'
updater | 2024/02/28 05:32:06 ERROR <job_b953c878-408a-4ca7-8487-b8a9449dbfd9> bin/update_files.rb:24:in '<main>'

Images of the diff or a link to the PR, issue, or logs

I'm 99% sure it came from #8963 specifically the changes made in updater/lib/dependabot/dependency_snapshot.rb
@jpinz jpinz added the T: bug 🐞 Something isn't working label Feb 29, 2024
@jpinz jpinz self-assigned this Feb 29, 2024
@jpinz
Copy link
Collaborator Author

jpinz commented Feb 29, 2024

@jakecoffman when you get a chance, would appreciate any feedback here.

@abdulapopoola abdulapopoola added the F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR label Feb 29, 2024
@jpinz
Copy link
Collaborator Author

jpinz commented Mar 1, 2024

Appears that the issue here was due to setting directory to / when directories was present and not empty. Not setting directory appears to have fixed the issue.

@jpinz jpinz closed this as completed Mar 1, 2024
@abdulapopoola
Copy link
Member

This sounds like something customers will also run into; what are our plans for this?

Tagging @carogalvin

@abdulapopoola abdulapopoola reopened this Mar 1, 2024
@abdulapopoola abdulapopoola added the T: feature-request Requests for new features label Mar 19, 2024
@abdulapopoola
Copy link
Member

@jpinz , does this still repro?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpinz jpinz

Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR T: bug 🐞 Something isn't working T: feature-request Requests for new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abdulapopoola @jpinz