Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open PR's for security sub-dependencies if there is an update for the parent #2082

Closed
marcaddeo opened this issue Nov 14, 2019 · 2 comments
Labels
F: noise related to Dependabot being noisy, or initiatives to make Dependabot quieter F: version-updates ⬆️ Issues specific to version updates T: feature-request Requests for new features

Comments

@marcaddeo
Copy link

So we're running Drupal 8, and using Composer to manage our dependencies. Yesterday symfony put out a security update, which is a sub-dependency of drupal/core. Drupal also put out a security update that updates the symfony/* dependencies.

Today, Dependabot is opening PR's for each symfony/* sub-dependency instead of just updating drupal/core which would update all of them at once.

It would be ideal for Dependabot to be able to resolve the fact that updating the single parent dependency would also update all the sub-dependencies security updates.

@marcaddeo marcaddeo changed the title Don't open PR's for security sub-dependencies if there is an update for the parent. Don't open PR's for security sub-dependencies if there is an update for the parent Nov 14, 2019
@rebelagentm
Copy link
Contributor

Thank you for opening this! We're pretty swamped at the moment, but we'll take this into consideration as soon as we can.

@infin8x infin8x transferred this issue from dependabot/feedback Jun 29, 2020
@infin8x infin8x added F: version-updates ⬆️ Issues specific to version updates T: feature-request Requests for new features F: noise related to Dependabot being noisy, or initiatives to make Dependabot quieter labels Jul 20, 2020
@jeffwidman
Copy link
Member

👋 sorry for the slow followup here.

I understand the use case, it makes complete sense as a human. But I don't see a straightforward way to automagically handle this in a consistent way. There are all kinds of edge cases here... for example, if an underlying security update is high severity, but the overall parent project has a low severity risk and requires a breaking change, then the user may only wish to merge the underlying sub dep PR and not the parent PR... so we'd be making some assumptions that may be incorrect if we only open one PR.

What we do instead today is give you all the PR's (which is annoying, I get it) but then as soon as you decide to merge the parent dependency PR, Dependabot will realize that the subdep PR's are no longer needed and automatically close them all.

I'm going to close, but if for some reason I'm overlooking an obvious solution here feel free to comment and we can re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: noise related to Dependabot being noisy, or initiatives to make Dependabot quieter F: version-updates ⬆️ Issues specific to version updates T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

4 participants