Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle leading "v" in versions in a commit message #244

Closed
jonmcquillan opened this issue Aug 19, 2022 · 2 comments · Fixed by #338
Closed

Handle leading "v" in versions in a commit message #244

jonmcquillan opened this issue Aug 19, 2022 · 2 comments · Fixed by #338
Labels
enhancement New feature or request

Comments

@jonmcquillan
Copy link
Contributor

eg Bumps org/repo from v1.3.0 to v1.3.2. as a commit message does not populate the previous-version and new-version, so is also unable to calculate the proper update-type. This makes the output not very useful for determining whether to auto merge a dependabot PR only on minor version changes or less for example.

@jonmcquillan jonmcquillan added the enhancement New feature or request label Aug 19, 2022
@jonmcquillan
Copy link
Contributor Author

Something like this maybe? #245

@jeffwidman
Copy link
Member

jeffwidman commented Apr 7, 2023

Makes sense, this should get fixed.

Input: Bumps org/repo from v1.3.0 to v1.3.2

Expected output:
previous-version: "v1.3.0"
new-version: "v1.3.2"
update-type: "version-update:semver-patch"

In other words, the "handling" should strip the leading v when calculating the update-type, but not actually strip it when populating the final "previous-version" / "new-version"...

That way the behavior is consistent between the version coming from the library and the action so users don't have to translate back and forth if they do additional processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants