Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No differentiation between indirect:production and indirect:development types #43

Closed
JacobEvelyn opened this issue Jun 24, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@JacobEvelyn
Copy link

The README says we should get dependency-type info like direct:production, which conveys information along two axes: direct/indirect and production/development. But in our PRs, I'm just seeing e.g. indirect as the only type information, which makes it hard for us to do things like "auto-merge any development dependency update."

Would it be possible to change this so it always has both pieces of information?

@JacobEvelyn JacobEvelyn added the bug Something isn't working label Jun 24, 2021
@JacobEvelyn
Copy link
Author

Ah, @feelepxyz @brrygrdn I see in output.ts that indirect dependencies don't get labeled as production or development. Is there a reason for this? I know an indirect dependency can be used by both production and development dependencies, but I assume the logic would be to treat that case as indirect:production.

We're trying to automate merging of all development dependency updates, including indirect ones, but to do that we need this additional information.

@JacobEvelyn JacobEvelyn changed the title Dependency type information not as detailed here as in README No differentiation between indirect:production and indirect:development types Jul 6, 2021
@feelepxyz
Copy link
Contributor

@JacobEvelyn this is currently a limitation in dependabot. The current dependency data model in dependabot-core doesn't support tracking the group for indirect dependencies so not a trivial fix unfortunately. I'm keen to rejig the data-model for a bunch of reasons but will be quite a while before we can get to it.

@JacobEvelyn
Copy link
Author

@feelepxyz gotcha, thanks for the context.

@brrygrdn
Copy link
Contributor

We've updated our documentation to reflect this limitation in core, so I'm going to close this out for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants