This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Silently pass on unsupported versions of Node.js #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to have depedency-check v3 as part of their CI build pipeline without being required to remove EoL versions of Node.js from their build matrix.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Sep 12, 2018
Version 3.2.1 was just released which no longer works on Node.js 4. Version 3.x never officially supported Node.js 4, but did run fine until now. This commit and be reverted once the following PR is released: dependency-check-team/dependency-check#99
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Sep 12, 2018
Version 3.2.1 was just released which no longer works on Node.js 4. Version 3.x never officially supported Node.js 4, but did run fine until now. This commit and be reverted once the following PR is released: dependency-check-team/dependency-check#99
watson
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Sep 12, 2018
Version 3.2.1 was just released which no longer works on Node.js 4. Version 3.x never officially supported Node.js 4, but did run fine until now. This commit and be reverted once the following PR is released: dependency-check-team/dependency-check#99
|
Released as |
|
No worries 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Node.js <6 haven't been officially supported by
dependency-checksince version 3, it did technically work until v3.2.1 was released as thedebugdependency now uses theletkeyword and therefore fails when being required.This PR allows users to have
depedency-checkv3 as part of their CI build pipeline without being required to remove EoL versions of Node.js from their build matrix.This escape hatch is similar to the one used in the standard linter.