Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug ( skip ) npm vulnerabilities #135

Closed
thib3113 opened this issue Apr 24, 2019 · 2 comments
Closed

Bug ( skip ) npm vulnerabilities #135

thib3113 opened this issue Apr 24, 2019 · 2 comments
Labels

Comments

@thib3113
Copy link
Contributor

Describe the bug
Using a report from a node.js project, doesn't report all vulnerabilities ( node.js checker add some vulnerabilities from NVD, or from npm, and NPM doesn't use the same format )

To Reproduce
Steps to reproduce the behavior:

  1. Run dependency-checker on a node project, with vulnerability
  2. Run sonarqubescanner
  3. See the vulnerabilities coming from npm are skipped

Current behavior
Vulnerabilities reported by NPM are skipped

Expected behavior
The plugin send npm vulnerabilities to sonarqube

Versions (please complete the following information):

  • dependency-check : 5.0.0-M2
  • sonarqube : 7.7
  • dependency-check-sonar-plugin : 1.2.3

Additional context
I'll push a merge request, containing :

  • failing test ( just loading the report )
  • complete report.xml ( 6MB, unreadable by human, can be used for bench test )
  • short report.xml ( containing a vulnerability from nvd, one from npm, and one without vulnerability) .
    ( the project is not so big, So I think report.xml can be really huge ) .
@Reamer
Copy link
Member

Reamer commented Jun 2, 2019

Can you check the Snapshot-Build if this issue is still present?

@Reamer
Copy link
Member

Reamer commented Jun 4, 2019

Fixed with 1.2.4

@Reamer Reamer closed this as completed Jun 4, 2019
Reamer added a commit that referenced this issue Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants