-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kotlin dsl support #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
requested changes
Oct 28, 2019
examples/single-module-kotlin-dsl-gradle/src/main/java/com/example/HelloWorld.java
Outdated
Show resolved
Hide resolved
Reamer
requested changes
Nov 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get the example working with
14:07 $ git diff
diff --git a/examples/single-module-kotlin-dsl-gradle/build.gradle.kts b/examples/single-module-kotlin-dsl-gradle/build.gradle.kts
index 194a3e5..78e105a 100644
--- a/examples/single-module-kotlin-dsl-gradle/build.gradle.kts
+++ b/examples/single-module-kotlin-dsl-gradle/build.gradle.kts
@@ -3,7 +3,7 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
plugins {
application
kotlin("jvm") version "1.3.50"
- id("org.sonarqube") version "2.6.2"
+ id("org.sonarqube") version "2.8"
id("org.owasp.dependencycheck") version "5.2.2"
}
@@ -31,9 +31,9 @@ dependencyCheck {
sonarqube {
properties {
- property("sonar.dependencyCheck.reportPath", "build/reports/dependency-check-report.xml")
+ property("sonar.dependencyCheck.xmlReportPath", "build/reports/dependency-check-report.xml")
property("sonar.dependencyCheck.htmlReportPath", "build/reports/dependency-check-report.html")
- property("sonar.sources", "${properties["sonar.sources"].toString()},build.gradle.kts")
+ property("sonar.sources", "src,build.gradle.kts")
}
}
Can you run the example project without errors?
Without I get this error:
14:23 $ gradle sonarqube
> Task :sonarqube FAILED
Invalid value of sonar.sources for single-module-kotlin-dsl-gradle
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':sonarqube'.
> The folder '[/home/philipp/git/dependency-check-sonar-plugin/examples/single-module-kotlin-dsl-gradle/src/main/kotlin]' does not exist for 'single-module-kotlin-dsl-gradle' (base directory = /home/philipp/git/dependency-check-sonar-plugin/examples/single-module-kotlin-dsl-gradle)
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 2s
2 actionable tasks: 1 executed, 1 up-to-date
You're absolutely correct about your changes. Sorry for that, i just build it and don't check if the sonarqube tasks works. Thanks for your open Eye! |
Reamer
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #163