Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v5.1.2 to loosen node version restriction #201

Closed
viceice opened this issue Nov 17, 2022 · 8 comments
Closed

release v5.1.2 to loosen node version restriction #201

viceice opened this issue Nov 17, 2022 · 8 comments

Comments

@viceice
Copy link

viceice commented Nov 17, 2022

Currently the version v5.1.1 don't allow node v18, so install fails on that node version.

So please release a bugfix with will allow any node version >= 16.0.0

It's already fixed on v5.x branch:

"node": "^10 || ^12 || >=14"

@joscha
Copy link
Collaborator

joscha commented Nov 20, 2022

Is there any chance you can upgrade to v6?

@viceice
Copy link
Author

viceice commented Nov 20, 2022

not directly, as this is a transitive dependency 🤷‍♂️

@joscha
Copy link
Collaborator

joscha commented Nov 20, 2022

not directly, as this is a transitive dependency 🤷‍♂️

are we talking about
https://github.com/pahen/madge/blob/c12ef70836855df7b9c34e5d93dfd34fdcae230d/package.json#L55 or something else?

@viceice
Copy link
Author

viceice commented Nov 20, 2022

yes

@joscha
Copy link
Collaborator

joscha commented Nov 20, 2022 via email

@viceice
Copy link
Author

viceice commented Nov 20, 2022

i understand, but it seems madge isn't merging the update PR. maybe there's no maintainer. 😕

@viceice
Copy link
Author

viceice commented Nov 20, 2022

PR is open since 4 month 😕

@joscha
Copy link
Collaborator

joscha commented Dec 4, 2022

I just published 5.1.3, hope that helps!

@joscha joscha closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants