Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow alternative fs to be used for reading files. #65

Open
dazinator opened this issue Dec 9, 2018 · 1 comment
Open

Allow alternative fs to be used for reading files. #65

dazinator opened this issue Dec 9, 2018 · 1 comment

Comments

@dazinator
Copy link
Contributor

Driver for this is: pahen/madge#186
I'll submit a PR

It looks like the only place fs is used currently is to read a tsconfig file here: https://github.com/dependents/node-filing-cabinet/blob/master/index.js#L197
@dazinator
Copy link
Contributor Author

Actually I'll probably have to get the typescript compiler / host to read files from the alternate fs implementation too. There are hooks for that I beleive.

@dazinator dazinator mentioned this issue Dec 10, 2018
Closed
15 tasks
dazinator added a commit to dazinator/node-filing-cabinet that referenced this issue Mar 18, 2019
@dazinator
dependents#65 - CommonJS Lookup supports alternative fs.
259b6f9
dazinator added a commit to dazinator/node-filing-cabinet that referenced this issue Mar 18, 2019
@dazinator
dependents#65 - Update module-definition dependency.
9445a42 
Tests passing.
dazinator added a commit to dazinator/node-filing-cabinet that referenced this issue Mar 19, 2019
@dazinator
dependents#65 - Amd Resolver test passing with aternative fs.
1de6e05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow using an alternate fs for lookup of sources dazinator/node-filing-cabinet
1 participant
@dazinator