Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the resolved partial is extensionless, then find a file like it #8

Closed
mrjoelkemp opened this issue May 18, 2016 · 0 comments
Closed

If the resolved partial is extensionless, then find a file like it #8

mrjoelkemp opened this issue May 18, 2016 · 0 comments

Comments

@mrjoelkemp
Copy link
Collaborator

mrjoelkemp commented May 18, 2016 •
edited

When you're importing templates or styles, it's incorrect to assume that they have the same extension as the file importing them.

Consumers shouldn't have to guard against this non-existent result.

  • Since we don't load require plugins, we don't know what the correct file extension should be.
    • The hogan loader hardcodes that it resolves .mustache files. We have no way of knowing that outside of the plugin.
  • Think about minified files that look like they're a real file (they have .min as an extension).
  • Do all partial resolutions result in a path without a file extension?
@mrjoelkemp mrjoelkemp mentioned this issue May 19, 2016
Closed
mrjoelkemp added a commit to dependents/node-dependency-tree that referenced this issue May 21, 2016
@mrjoelkemp
Remove logic to strip loaders
9a56f70 
There's no need to skip files that use loaders. In fact, we want
those files to be properly resolved since they're part of the
dependency tree of a module.

We skipped them only because module-lookup-amd couldn't handle
those files.

Ref dependents/node-module-lookup-amd#8
@mrjoelkemp mrjoelkemp mentioned this issue May 21, 2016
Merged
mrjoelkemp added a commit to dependents/node-dependents-editor-backend that referenced this issue May 25, 2016
@mrjoelkemp
Tree: Initial support w/ tests
c23abc0 
Fixes #17
Ref dependents/node-module-lookup-amd#8
mrjoelkemp added a commit to dependents/node-dependents-editor-backend that referenced this issue May 25, 2016
@mrjoelkemp
Tree: Initial support w/ tests
9d5f260 
Fixes #17
Ref dependents/node-module-lookup-amd#8
mrjoelkemp added a commit to dependents/node-dependents-editor-backend that referenced this issue May 25, 2016
@mrjoelkemp
Tree: Initial support w/ tests
e64cbf5 
Fixes #17
Ref dependents/node-module-lookup-amd#8
@mrjoelkemp mrjoelkemp mentioned this issue May 25, 2016
Closed
mrjoelkemp added a commit to dependents/node-dependents-editor-backend that referenced this issue May 25, 2016
@mrjoelkemp
Tree: Initial support w/ tests
b765f73 
Fixes #17
Ref dependents/node-module-lookup-amd#8
mrjoelkemp added a commit to dependents/node-dependency-tree that referenced this issue Jun 3, 2016
@mrjoelkemp
Remove logic to strip loaders
5d8c4b5 
There's no need to skip files that use loaders. In fact, we want
those files to be properly resolved since they're part of the
dependency tree of a module.

We skipped them only because module-lookup-amd couldn't handle
those files.

Ref dependents/node-module-lookup-amd#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrjoelkemp