Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detective-typescript uses an unsupported version of typescript #50

Closed
luisnaranjo733 opened this issue Oct 22, 2018 · 1 comment
Closed

Comments

@luisnaranjo733
Copy link

When I run madge, I get this TS warning

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-eslint-parser.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: ~3.0.1

YOUR TYPESCRIPT VERSION: 3.1.3 

I opened an issue on typescript-eslint-parser, and we've found that the reason is that detective-typescript declares a TS version that is slightly higher than what typescript-eslint-parser supports.

We should either downgrade the version here, or work with typescript-eslint-parser to get it to raise its supported version. There's not much different between the two versions, they may just need to verify that this version works.

@mrjoelkemp
Copy link
Collaborator

Hey @luisnaranjo733! Thanks for reporting. I had some hassles wrangling an appropriate version of typescript to get the warnings to go away in our test suite.

Though I agree that this could/should be resolved upstream, I'm reluctant to downgrade here unless there's a clear breakage due to the version discrepancy (which I wouldn't expect since 3.1.3 is a minor and few patches away from the "supported" version).

I'd appreciate the help in working with upstream folks to get this squared away. Until then, this seems like a wontfix.

I'm happy to continue the discussion around this if there's a functional issue that I'm missing.

Thanks again for contributing.

ZhenyuCheng pushed a commit to ZhenyuCheng/node-precinct that referenced this issue Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants