added support for vue single file components #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @Havunen. Do you have a sense of how to fix the dependency issue for Node 12 and 14? Looks it works fine on 16 an 18 (I'm running 18 locally and it works fine). Looks like detective-vue2 is also stating support for Node 12 and above. Curious if you found similar issues in your CI builds. Thanks. |
|
Hmm, it seems the build fails because it cant find vue compiler, maybe its because I added it as peerDepency. |
|
@Havunen the new dep should be in dependencies. This branch also needs a rebase and tests should pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/Havunen/detective-vue2 for parsing vue files
Relates to pahen/madge#122