Merge pull request #423 from DriverX/fix_lock_attr_default

Fix Converter.lock default value for subclasses

dephell/converters/conda.py

@@ -4,6 +4,7 @@
 from typing import Optional
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 from dephell_specifier import RangeSpecifier
 from packaging.utils import canonicalize_name
@@ -16,6 +17,7 @@
 from .base import BaseConverter
 
 
+@attr.s()
 class CondaConverter(BaseConverter):
     def can_parse(self, path: Path, content: Optional[str] = None) -> bool:
         if isinstance(path, str):

dephell/converters/egginfo.py

@@ -7,6 +7,7 @@
 from typing import Dict, Optional
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 from dephell_links import parse_link
 from dephell_markers import Markers
@@ -401,9 +402,10 @@ def _format_req(req, with_envs: bool) -> str:
         return line
 
 
+@attr.s()
 class EggInfoConverter(_Reader, _Writer, BaseConverter):
     """
     PEP-314, PEP-345, PEP-566
     https://packaging.python.org/specifications/core-metadata/
     """
-    lock = False
+    lock = attr.ib(type=bool, default=False)

dephell/converters/flit.py

@@ -4,6 +4,7 @@
 from typing import Optional
 
 # external
+import attr
 import tomlkit
 from dephell_discover import Root as PackageRoot
 from dephell_specifier import RangeSpecifier
@@ -17,8 +18,9 @@
 from .egginfo import EggInfoConverter
 
 
+@attr.s()
 class FlitConverter(BaseConverter):
-    lock = False
+    lock = attr.ib(type=bool, default=False)
 
     def can_parse(self, path: Path, content: Optional[str] = None) -> bool:
         if not content:

dephell/converters/imports.py

@@ -4,6 +4,7 @@
 from typing import Dict, List, Set
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 
 # app
@@ -23,8 +24,9 @@
 CACHE_TTL = 3600 * 24 * 30  # 30 days
 
 
+@attr.s()
 class ImportsConverter(BaseConverter):
-    lock = True
+    lock = attr.ib(type=bool, default=True)
 
     def can_parse(self, path: Path, content: str = None) -> bool:
         if isinstance(path, str):

dephell/converters/installed.py

@@ -4,6 +4,7 @@
 from typing import Iterable, Union
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 from packaging.utils import canonicalize_name
 
@@ -15,8 +16,9 @@
 from .wheel import WheelConverter
 
 
+@attr.s()
 class InstalledConverter(BaseConverter):
-    lock = True
+    lock = attr.ib(type=bool, default=True)
 
     _blacklist = {
         'pkg-resources',        # https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1635463

dephell/converters/pip.py

@@ -5,6 +5,7 @@
 from typing import Optional
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 from dephell_links import DirLink, FileLink
 from pip._internal.req import parse_requirements
@@ -33,6 +34,7 @@
         from pip._internal.network.session import PipSession
 
 
+@attr.s()
 class PIPConverter(BaseConverter):
     sep = ' \\\n  '
 

dephell/converters/pipfile.py

@@ -3,6 +3,7 @@
 from typing import List, Optional
 
 # external
+import attr
 import tomlkit
 from dephell_discover import Root as PackageRoot
 from dephell_pythons import Pythons
@@ -19,8 +20,10 @@
 VCS_LIST = ('git', 'svn', 'hg', 'bzr')
 
 
+@attr.s()
 class PIPFileConverter(BaseConverter):
-    lock = False
+    lock = attr.ib(type=bool, default=False)
+
     fields = (
         'version', 'editable', 'extras', 'markers',
         'ref', 'vcs', 'index', 'hashes',

dephell/converters/pipfilelock.py

@@ -6,6 +6,7 @@
 from typing import Optional
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 from dephell_pythons import Pythons
 from dephell_specifier import RangeSpecifier
@@ -22,8 +23,9 @@
 # https://github.com/pypa/pipfile/blob/master/pipfile/api.py
 
 
+@attr.s()
 class PIPFileLockConverter(PIPFileConverter):
-    lock = True
+    lock = attr.ib(type=bool, default=True)
 
     def can_parse(self, path: Path, content: Optional[str] = None) -> bool:
         if isinstance(path, str):

dephell/converters/poetry.py

@@ -4,6 +4,7 @@
 from typing import List, Optional
 
 # external
+import attr
 import tomlkit
 from dephell_discover import Root as PackageRoot
 from dephell_specifier import RangeSpecifier
@@ -16,8 +17,10 @@
 from .base import BaseConverter
 
 
+@attr.s()
 class PoetryConverter(BaseConverter):
-    lock = False
+    lock = attr.ib(type=bool, default=False)
+
     fields = (
         'version', 'python', 'platform', 'allows-prereleases',
         'optional', 'extras', 'develop',

dephell/converters/poetrylock.py

@@ -4,6 +4,7 @@
 from typing import List, Optional
 
 # external
+import attr
 import tomlkit
 from dephell_discover import Root as PackageRoot
 from dephell_links import DirLink
@@ -16,8 +17,10 @@
 from .base import BaseConverter
 
 
+@attr.s()
 class PoetryLockConverter(BaseConverter):
-    lock = True
+    lock = attr.ib(type=bool, default=True)
+
     fields = (
         'category', 'description', 'name', 'marker', 'optional',
         'python-versions', 'version', 'dependencies',

dephell/converters/pyproject.py

@@ -3,6 +3,7 @@
 from typing import Optional
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 from packaging.requirements import Requirement
 from tomlkit import document, dumps, parse
@@ -13,8 +14,9 @@
 from .base import BaseConverter
 
 
+@attr.s()
 class PyProjectConverter(BaseConverter):
-    lock = False
+    lock = attr.ib(type=bool, default=False)
 
     def can_parse(self, path: Path, content: Optional[str] = None) -> bool:
         if isinstance(path, str):

dephell/converters/sdist.py

@@ -25,7 +25,7 @@ class SDistConverter(BaseConverter):
     # ratio of tests and project size after which tests will be excluded from sdist
     ratio = attr.ib(type=Optional[float], default=None)
 
-    lock = False
+    lock = attr.ib(type=bool, default=False)
 
     def can_parse(self, path: Path, content: Optional[str] = None) -> bool:
         if content is not None:

dephell/converters/setuppy.py

@@ -6,6 +6,7 @@
 from typing import Optional
 
 # external
+import attr
 from dephell_discover import Root as PackageRoot
 from dephell_links import DirLink, FileLink, URLLink, VCSLink, parse_link
 from dephell_setuptools import read_setup
@@ -54,8 +55,9 @@
 """
 
 
+@attr.s()
 class SetupPyConverter(BaseConverter):
-    lock = False
+    lock = attr.ib(type=bool, default=False)
 
     def can_parse(self, path: Path, content: Optional[str] = None) -> bool:
         if isinstance(path, str):

dephell/converters/wheel.py

@@ -8,6 +8,7 @@
 from zipfile import ZIP_DEFLATED, ZipFile, ZipInfo
 
 # external
+import attr
 from dephell_archive import ArchivePath
 from dephell_discover import Root as PackageRoot
 
@@ -207,9 +208,10 @@ def make_records(self, path: str) -> str:
         return content + ('\n{},,'.format(path))
 
 
+@attr.s()
 class WheelConverter(_Reader, _Writer, BaseConverter):
     """
     PEP-0427
     https://www.python.org/dev/peps/pep-0427/
     """
-    lock = False
+    lock = attr.ib(type=bool, default=False)

tests/requirements/setup.py

@@ -5,7 +5,6 @@
 # external
 from setuptools import setup
 
-
 here = path.abspath(path.dirname(__file__))
 root = path.dirname(path.dirname(here))
 with open(path.join(root, 'README.md'), encoding='utf-8') as f: