Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Commit

Permalink
Merge pull request #366 from dephell/simplify-graph-clear
Browse files Browse the repository at this point in the history
Simplify graph cleaning
  • Loading branch information
orsinium committed Jan 27, 2020
2 parents 10a1093 + e7dc511 commit c80f8fa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 4 additions & 2 deletions dephell/controllers/_resolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ def resolve(self, debug: bool = False, silent: bool = False, level: Optional[int
with spinner as spinner:
while True:
resolved = self._resolve(debug=debug, silent=silent, level=level, spinner=spinner)
if resolved is not None:
return resolved
if resolved is None:
continue
self.graph.clear() # remove unused deps from graph
return resolved

def _resolve(self, debug: bool, silent: bool, level: Optional[int], spinner) -> Optional[bool]:
if silent:
Expand Down
3 changes: 0 additions & 3 deletions dephell/models/requirement.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def __init__(self, dep, lock: bool, roots: Iterable[str] = None):
def from_graph(cls, graph, *, lock: bool) -> Tuple['Requirement', ...]:
result = OrderedDict()
extras = defaultdict(list)
applied = graph.applied
roots = [root.name for root in graph.get_layer(0)]

# if roots wasn't applied then apply them
Expand All @@ -39,8 +38,6 @@ def from_graph(cls, graph, *, lock: bool) -> Tuple['Requirement', ...]:
# get all nodes
for layer in reversed(graph._layers[1:]): # skip roots
for dep in sorted(layer):
if applied and not dep.applied:
continue
if dep.constraint.empty:
continue
if dep.extra is None:
Expand Down

0 comments on commit c80f8fa

Please sign in to comment.