-
Notifications
You must be signed in to change notification settings - Fork 118
Change --tag
option from bool to template in project:bump command
#199
Conversation
For example: use `--tag v.{new_version}` for git tag `v.3.1.2`
Beautiful. Thank you! I think, we can use |
Good proposal, I implemented the prefix feature! But I concerned about testing git tag feature, how can I test it? |
Oh, that's a long story. We have to make temporary directory, |
Added tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! It's a big step to the perfect tests and important contribution.
I've added a few comments on how to make it a little bit better. However, important only 2 of them: about the error message and about documentation. It's the things that users see. Everything isn't really important, but it would be cool if you've done it BTW.
Perfect, thank you :) Tonight Travis CI has troubles with Linux build, so, I'll merge it tomorrow, if tests works |
Thank you, nice job. If you'll have time and willing to help more, we have a bug #127 related to the usage of |
Closes #197
I have questions about three things:
poetry run dephell
command, but I'm not sure about it.