[Dark] [Light] [HTML] Too much italics in STYLE element.

[Zegnat]

Currently you are setting source.css.embedded.html to italics. This is wrong. Only the tag name (style) should use italics. The way it is set-up now attributes (likes type) and the tag itself (< and >) use italics as well.

• source.css.embedded.html should use the regular font.
• source.css.embedded.html entity.name.tag.style.html should use the italic font.

[deplorableword]

This issue is now fixed in light and dark, thanks for spotting it. 8626d5f

[Zegnat]

It’s not fixed for me. The type attribute it still displayed in italics. Another clear sign of this bug is how ID selectors (#id) are being italicised.

The culprit seems to be “HTML: Embeddable” which sets source.css.embedded.html to italic. It seems this rule is used to italicise the <!-- --> used to hide CSS from ancient browsers? I’ve been toying around with it but it seems impossible to italicise only the HTML comment…

This TextMate selector was the closest I got: source.css.embedded.html - entity - meta - punctuation.

This will pass on any entity (these are attributes inside the style tag), any meta (these are all matched CSS elements, eg. selectors) and any punctuation (these match the < and > of the style tag). This is only close because it will still italicise characters within the tag that it doesn’t have other selectors for, like the = between the attribute name and value.

(Incidentally this also means the = takes on the colour set to source.css.embedded.html making it a lighter base colour than it should be.)

[deplorableword]

How does this look?

http://i52.tinypic.com/qznkp4.png

[Zegnat]

Yes, that is the only other real solution: to not italicise source.css.embedded.html at all.

It also looks like it’s a too light base colour or is that just me? Comments (in Dark) would normally be base01 (#586E75) according to Solarized Usage & Development.

(Sorry, I accidentally hit “Comment & Close”.)

[deplorableword]

Cool, I'll go ahead and merge in that change.

[deplorableword]

Just added in those changes, I've also learned you can prevent a selector from inheriting italics by setting an unsetting italics in theme editor which creates an empty fontStyle.