Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl -LO undefined #63

Closed
michielgerritsen opened this issue Apr 21, 2023 · 3 comments · Fixed by #65
Closed

curl -LO undefined #63

michielgerritsen opened this issue Apr 21, 2023 · 3 comments · Fixed by #65

Comments

@michielgerritsen
Copy link

michielgerritsen commented Apr 21, 2023

Hey,

When running this I'm getting this error:

Downloading "undefined".
$ curl -LO undefined
curl: Remote file name has no length!
curl: (23) Failed writing received data to disk/application
Error: curl: Remote file name has no length!

The curl command that triggers this error can be found here:
https://github.com/deployphp/action/blob/master/index.js#L101

I tried to trace down the issue, and I'm guessing it's caused by the fact that the project is using Deployer version 7.3.1, but this is not (yet) in the manifest.json.

There is a check in place if the url == null but it seems that the value is actually undefined.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@piotrkwiecinski
Copy link
Contributor

piotrkwiecinski commented May 1, 2023

Until it's fixed you can use these steps to use the latest version of Deployer:

- name: Download `deployer.phar`
  run: composer global require deployer/deployer:${{vars.DEPLOYER_VERSION}} --no-interaction --verbose --ansi
- name: Get composer global bin-dir path
  id: composer-bin-dir
  run: echo "path=$(composer global config bin-dir --absolute)" >> $GITHUB_OUTPUT
- name: Deploy
  uses: deployphp/action@v1
  with:
    deployer-binary: ${{ steps.composer-bin-dir.outputs.path }}/dep        

It's what I have in my pipeline.

@michielgerritsen
Copy link
Author

Maybe I should have added this: To fix it for now I run a composer install in the project, so the deployer binary from the vendor folder is used :-)

@hashimaziz1
Copy link

hashimaziz1 commented Oct 19, 2023

This doesn't seem to have been fixed yet in 7.3.1. Any idea when it will be without requiring the extra step above? For what it's worth, my workflow has the following to install composer dependencies but it doesn't seem to make a difference:

  - name: Run Composer install for production
    run: composer install -o -q --no-dev --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants