Skip to content

Commit

Permalink
Simplify loop in releases_list (#3471)
Browse files Browse the repository at this point in the history
* Avoid calling count() in loop
* Remove extra variable for release name
* Reverse the array before for clarity
  • Loading branch information
ocean90 committed Jan 30, 2023
1 parent 8a94172 commit 1fb2d6f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions recipe/deploy/release.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@
return basename(rtrim(trim($release), '/'));
}, $ll);

$releasesLog = get('releases_log');
// Return releases from newest to oldest.
$releasesLog = array_reverse(get('releases_log'));

$releases = [];
for ($i = count($releasesLog) - 1; $i >= 0; --$i) {
$release = $releasesLog[$i]['release_name'];
if (in_array($release, $ll, true)) {
$releases[] = $release;
foreach ($releasesLog as $release) {
if (in_array($release['release_name'], $ll, true)) {
$releases[] = $release['release_name'];
}
}
return $releases;
Expand Down

0 comments on commit 1fb2d6f

Please sign in to comment.