Bump passphrase timeout to 30secs, check if process is running

[barryvdh]

Q	A
Bug fix?	Yes
New feature?	No
BC breaks?	No
Deprecations?	No
Fixed tickets	#1220

This bumps the wait time for a passphrase to 30 secs. It also checks if the process is running, otherwise throw an immediate exception (for example, after entering the wrong passphrase)

[antonmedv]

It also checks if the process is running,

What for?

[barryvdh]

The ssh multiplex command is supposed to keep running in the background, right?
If it fails (eg. connection can't be made, passphrase is not entered correctly) the process exits. So if we keep waiting, it will fail after the timeout (30 secs), instead of directly.

[antonmedv]

Master connection detaches, doesn't it?

[barryvdh]

Not sure, doesn't seem to in my case. When I run the command manually, it just sets up an SSH connection with exiting. Or is that not intended?
I thought you were using start instead of run to run it in the background until the deployment finishes.

Should I remove the check then?

[antonmedv]

Should I remove the check then?

I'll test it.

I found two cases: in homestad master stick to process, but on my macos it doesn't.

Can you check in homestad?

[barryvdh]

With sticks to process, you mean it keeps the process running? That is the same as in CentOS. I can give it a try on the mac, but if there is not way to detect if it's pending, we should just let it fail. Or perhaps we could still get some output of the failing.

[barryvdh]

On my Mac is seems to have the same behavior.

One thing that I'm encountering is that is run the deploy:failed task after. Depending on the hooks (eg. after(‘deploy:failed’, ‘deploy:unlock’);), it runs more commands, which in turn ask for passphrases on the failed task. The exception is swallowed untill all tasks are run.

I think the flow should probably be something like this:

• First initialize SSH (multiplexing etc)
• If working, continue with the tasks (eg. prepare etc), if then failing, run the failed task
• If not working, abort before running any commands on the server to avoid multiple passphrase requests / swallowing the init message.

[antonmedv]

Nice, i think it will be good solution.

[barryvdh]

Is that something you are going to do?

[antonmedv]

No

[antonmedv]

Maybe you can do it?

[barryvdh]

I'll see. Do you still want to merge this first?

[barryvdh]

Ah, you already had something like this. I created an InitializationException whichs extends the GracefulShutdownException, which skips the failed task. This shuts down immediatly. Better?

[jconroy]

This bumps the wait time for a passphrase to 30 secs

FWIW this is working well combined with #1220, thanks for the fix @barryvdh (I was hitting the 5sec timeout)