-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --version option is not working properly #1351 #1354
Conversation
chellem
commented
Sep 1, 2017
Q | A |
---|---|
Bug fix? | Yes |
New feature? | No |
BC breaks? | No |
Deprecations? | No |
Fixed tickets | 1351 |
Please add comments about implementation, |
$version = $package['version']; | ||
} | ||
$composerLockFiles = array( | ||
realpath($deployFilePath . '/../composer.lock'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I don't find composer.lock in the same directory as $deployFilePath
} | ||
$composerLockFiles = array( | ||
realpath($deployFilePath . '/../composer.lock'), | ||
realpath(__DIR__ . '/../../../../composer.lock') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
../../../..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting the global composer.lock
@antonmedv the changes doesn't work? |
But it does working now:
|
After a lot fo thinking, I decided to go away from using version detection. Now version will be set manually every time before release. |