Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for GroupTask in invoke #1364

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Conversation

tseho
Copy link
Contributor

@tseho tseho commented Sep 17, 2017

Q A
Bug fix? Yes
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

Calling invoke on a GroupTask throw a Can't run group task. exception.
Using ScriptManager::getTasks and a SeriesExecutor allows to use invoke on GroupTasks.

@tseho tseho changed the title Feature invoke Adds support for GroupTask in invoke Sep 17, 2017
@antonmedv
Copy link
Member

Please, take a loot CI errors.

@tseho
Copy link
Contributor Author

tseho commented Sep 17, 2017

It's not "Tests failed.", it's "Test setup failed."
How can I restart the tests ?

@antonmedv
Copy link
Member

I'll restart.

@antonmedv antonmedv closed this Sep 18, 2017
@antonmedv antonmedv reopened this Sep 18, 2017
@antonmedv antonmedv merged commit e9cbb7f into deployphp:master Sep 19, 2017
@antonmedv
Copy link
Member

Please update CHANGELOG.md

tseho added a commit to tseho/deployer that referenced this pull request Sep 19, 2017
@tseho
Copy link
Contributor Author

tseho commented Sep 19, 2017

Do you want to revert & merge again for including the commit with the CHANGELOG.md update ?

@antonmedv
Copy link
Member

No, send new PR

tseho added a commit to tseho/deployer that referenced this pull request Sep 21, 2017
antonmedv added a commit that referenced this pull request Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants