Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHPUnit #1417

Merged
merged 6 commits into from Jan 2, 2018
Merged

Upgrade PHPUnit #1417

merged 6 commits into from Jan 2, 2018

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Nov 11, 2017

Q A
Bug fix? No
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

Brought to you by PHP CS Fixer

@antonmedv
Copy link
Member

Tests are falling.

@keradus
Copy link
Contributor Author

keradus commented Nov 12, 2017

Please, could you point where?
Travis is passing on all jobs.
Scrutinizer error is not on executing tests, but TEST SETUP FAILED with There was an error (Event-ID 753253043b4b4c4fb114847fc77591c0). I cannot fix internal Scrutinizer issues ;)

@antonmedv
Copy link
Member

Hmm, okay. I will check it myself.

@antonmedv antonmedv closed this Nov 12, 2017
@antonmedv antonmedv reopened this Nov 12, 2017
@antonmedv antonmedv added this to the 7.0 milestone Nov 29, 2017
@keradus
Copy link
Contributor Author

keradus commented Jan 2, 2018

ping @antonmedv

@antonmedv
Copy link
Member

Why did you refactored phpdocs? :)

@keradus
Copy link
Contributor Author

keradus commented Jan 2, 2018

because creator of PHPUnit ask you to
https://thephp.cc/news/2016/02/questioning-phpunit-best-practices

@antonmedv antonmedv merged commit 192078a into deployphp:master Jan 2, 2018
@keradus keradus deleted the phpunit branch January 3, 2018 11:57
antonmedv pushed a commit that referenced this pull request Apr 18, 2018
* Upgrade PHPUnit

* Update ScriptManagerTest.php

* Update InitializerTest.php

* Update GroupTaskTest.php

* Update HostSelectorTest.php

* Update DeployerTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants