Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact sensitive information provided by the user via askHiddenRespon… #1532

Closed
wants to merge 3 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 5, 2018

…se()

Q A
Bug fix? No
New feature? Yes
BC breaks? No
Deprecations? No
Fixed tickets #1527

strings which are provided by the end-user with askHiddenResponse() will be redacted in the outputstream and also in the logfile.

closes #1527

used in action

dep secret -vvv --log=deployer.log
➤ Executing task secret
tell me your secret
[localhost] > echo **SECRECT**
[localhost] < **SECRECT**
• done on [localhost]
✔ Ok [1s 919ms]

mstaab@mst16:/cluster/www/www/www/tools/dev/deploytest$ cat deployer.log
[localhost] > echo **SECRECT**
[localhost] < **SECRECT**

@antonmedv
Copy link
Member

This is a nice addition. Will look more closely on weekend. But I think of getting more common solution.

@antonmedv
Copy link
Member

Also check CI.

@staabm
Copy link
Contributor Author

staabm commented Feb 5, 2018

fixed the build.

I had the need for this feature therefore I implemented it in this simple form.
IMO we could land it in this simple form and do a more abstracted/common one in a later PR.

@staabm
Copy link
Contributor Author

staabm commented Feb 18, 2018

rebased. ping @antonmedv

@antonmedv
Copy link
Member

I think this cool feature can go to v7. Motivating people to upgrade (a lot still uses v3 :( )

@antonmedv antonmedv added this to the 7.0 milestone Feb 18, 2018
@antonmedv antonmedv closed this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow to mask sensitive output in verbose modes
2 participants