Don't touch files

[barryvdh]

Fixes #1540

Q	A
Bug fix?	Yes
New feature?	No
BC breaks?	Yes or No
Deprecations?	No
Fixed tickets	#1540

Removes the touch so that non-existing files are not created, possibly in an invalid format.

[antonmedv]

I'm afraid what this is breaking change. How can we figure this out?

[staabm]

I have the same feeling... this might be a breaking change... maybe this should be feature-flagged instead of beeing deleted, so you can opt-out from this touch call in your recipe.

[antonmedv]

I think we need to see history of this addition and why it was introduced in first place.

[barryvdh]

Yeah I was trying to, but at some time there was a large refactor so the history was hard to track down.

The symlink would still be created right? Just as a broken link, which (imho) is easier to notice then an empty file.

[gharlan]

I think we need to see history of this addition and why it was introduced in first place.

Apparently it was introduced along with whole deploy:shared task in 2014:
339baed#diff-17bfdc9b1a5d2375e8f0241c0bee0619R84

[barryvdh]

I guess we could also show a warning message when this doesn't exist, or fail.

But imho it seems to be more dangerous/unexpected to create an empty file, because some frameworks might check for the existence of a file and then require it or change behavior.

[antonmedv]

@gharlan your are right. Actually shared_dirs also created. What about them?

I think this is kind of breaking changes. I think to add this to v7 milestone.

[barryvdh]

So another use-case about this:
Magento has a 'maintenance' flag in 'var/.maintenance.flag'. If that exists, it's in maintenance mode, otherwise not. Currently you can't share that file, because if it doesn't exist you create it, so Magento thinks it's in maintenance mode..

[antonmedv]

Agree. Will be better to not create file. What about shared dirs?

[cafferata]

If you ask me, I would answer; no shared directory creation and an showing an warning message is enough. Because this situation will only occurs when you bootstrap the project. In our situation the shared directories contains an .gitkeep file to prevent from not existing.

[jordisala1991]

What about a flag to disable/enable this feature... and disabled by default, because otherwise it would be BC break

[antonmedv]

I think one more flag is redundant. Will merge in into v7 major release.