Show regular output when errorOutput is empty #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
approved these changes
Feb 17, 2018
antonmedv
pushed a commit
that referenced
this pull request
Apr 18, 2018
* Show regular output when errorOutput is empty * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications throw errors without correctly logging the output to
stderr. This is probably an error with the framework, but it makes it hard to debug errors. I've encountered this with both Magento2 and Laravel, the only solution is to re-run the deployment with -vvv to see the error.Proposed solution:
Show the regular output in RuntimeException, when the error output is empty.