Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Support] upgrade code to php 7.0 #1751

Closed
wants to merge 1 commit into from
Closed

[Support] upgrade code to php 7.0 #1751

wants to merge 1 commit into from

Conversation

rvitaliy
Copy link
Contributor

Q A
Bug fix? No
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

Improve code with php 7.0 syntax

@ahmadmayahi
Copy link
Contributor

The issue says upgrade code to PHP 7.0 but what you are doing is using the declare() function and return types in some of the files.

Could you please explain why only a few files have been changed?

@rvitaliy
Copy link
Contributor Author

@ahmadmayahi is a chain of several small PR to upgrade code to php 7 standards and make it more strict
see #1721, #1733, #1736

@rvitaliy rvitaliy closed this Jan 28, 2020
@rvitaliy rvitaliy deleted the feature/upgrade-code-to-php7-support branch January 28, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvitaliy @ahmadmayahi