Add check_remote_head option to avoid unnecessary new releases by che… #1759
Conversation
…cking the remote git HEAD without cloning the repo.
|
Build failed |
It keeps saying |
|
Try checkout CHANGELOG and run |
|
I tried that, but still get the same result: |
|
Really strange, will look at this tonight. |
|
@ahmadmayahi please, start with this PR. Try to figure out why CI doesn't passing. Maybe bug in changelog's parser. |
Removed extra spaces: #1759
|
@antonmedv, this is because @ahmadmayahi added spaces after the following line I submitted an pull request to the |
Update CHANGELOG.md
|
Thank you @cafferata |
recipe/deploy/prepare.php
Outdated
| get('bin/git'), $repository))); | ||
| if (true === get('check_remote_head') && null == input()->getOption('tag')) { | ||
| $headPath = trim(get('deploy_path').'/.dep/HEAD'); | ||
| $isRemoteHeadExists = test("[ -f $headPath ]"); |
There was a problem hiding this comment.
Is this check really required, or could it be achieved in combination with the „cat“ line in a single command?
Every remote command has a big overhead
There was a problem hiding this comment.
Well, cating non-existing file leads to STDERR.
I know, we could output the error to the 2>/dev/null but I think it's a hack, the right solution is to check whether the file exists or not.
There was a problem hiding this comment.
And something along the lines of
run('test -f '. $headPath ' && cat '.$headPath);
?
There was a problem hiding this comment.
How could test become a part of the run command? I guess you mean the output of test right?
There was a problem hiding this comment.
|
ping @antonmedv |
Checking the remote git HEAD without cloning the repo.
A new option
check_remote_headhas been added, when this option sets totruedeployer will not clone the repository if there are no changes found.Thanks to
git ls-remote, this command gets theHEADwithout cloning the repository.Revision is also checked, so if we run something like
dep deploy --revision=a69539703d917cafb1c51dad20f4ee1e317c3017deployer will also check for the revision.