Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style fixes #1762

Merged
merged 7 commits into from
Nov 11, 2018
Merged

Code style fixes #1762

merged 7 commits into from
Nov 11, 2018

Conversation

cafferata
Copy link
Contributor

@cafferata cafferata commented Nov 10, 2018 •
edited

Q A
Bug fix? No
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

Some small code styles fixes:

  1. Update missing argument in PHPDoc.
  2. Splits the IF-statement/workflow(s) for readability
  3. Replace double quotes to single quotes.
  4. Replaced alias functions by original functions.
  5. Define return types.
  6. Type casting can be used
  7. Non-optimal regular expression, \d is a subset of \w.

antonmedv
antonmedv requested changes Nov 10, 2018
View reviewed changes
bin/changelog Outdated Show resolved Hide resolved
bin/changelog Outdated Show resolved Hide resolved
bin/changelog Show resolved Hide resolved
src/Support/Changelog/Parser.php Outdated Show resolved Hide resolved
src/Support/Changelog/Parser.php Outdated Show resolved Hide resolved
src/Support/Changelog/Parser.php Outdated Show resolved Hide resolved
src/Support/Changelog/Parser.php Outdated Show resolved Hide resolved
@cafferata
Copy link
Contributor Author

I have removed, on your request, the two specific commits in this pull request.

  1. Using fully-qualified function calls is faster.
  2. Unnecessary variable overrides

@antonmedv
Copy link
Member

  1. Yes, but I this case it wouldn't increase speed.
  2. I think clean code is better anyway 🙃

@antonmedv antonmedv merged commit 2ad907e into deployphp:master Nov 11, 2018
@cafferata cafferata deleted the code-style-fixes branch November 11, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonmedv antonmedv antonmedv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cafferata @antonmedv