Add cd (change directory) and within (run commands within a directory and revert to the previous workingPath)

[tomzx]

Here's my take on the cd function. I've also added a within function which allows the user to provide a callback:

<?php

task('test', function() {
    cd('my_dir');
    within('{some_dir}', function() {
        run('some command');
    });
    // back in my_dir
});

After the within function is called, the environment is reverted to the previous working path.

This current implementation only support going to an absolute path. We may consider changing the implementation to support relative navigation if that is something people would want (I don't think that is the case though).

Reference: #177.

[antonmedv]

Add PhpDoc here, please.

[tomzx]

I've forced pushed the changes you've asked. Please take the time to review them.

Thanks!

[antonmedv]

Done 🍺

[antonmedv]

Hmmm.

It's not possible to write like this:

cd('{release_path}');

only like this:

cd(env('release_path'));

@tomzx Can you fix it?

[tomzx]

@Elfet Pretty sure that should work (at least it did when I wrote the functionality). I'll pull the latest changes and see if that still works.

Edit: Works fine for me:

task('test', function () {
    run('pwd');

    within('{deploy_path}/current', function() {
        run('pwd');
    });

    cd('{deploy_path}');
    run('pwd');
    cd('{deploy_path}/shared');
    run('pwd');

    within('{deploy_path}/current', function() {
        run('pwd');
    });

    run('pwd');
});

➤ Executing task test
⤷ on [production]
Run: cd /var/www/test-target && pwd
# /var/www/test-target
# 
Run: cd /var/www/test-target/current && pwd
# /var/www/test-target/current
# 
Run: cd /var/www/test-target && pwd
# /var/www/test-target
# 
Run: cd /var/www/test-target/shared && pwd
# /var/www/test-target/shared
# 
Run: cd /var/www/test-target/current && pwd
# /var/www/test-target/current
# 
Run: cd /var/www/test-target/shared && pwd
# /var/www/test-target/shared
# 
⤶ done on [production]
✔ OK

[antonmedv]

Hmmm, can you look at https://github.com/deployphp/deployer/blob/master/recipe/common.php#L134
Not working there :(

[tomzx]

I assume you're getting this error: PHP Fatal error: Maximum function nesting level of '100' reached, aborting!?

It has to do with the fact that resolving the environment variable release_path will generate a recursive call.

env('release_path', function () {
    return str_replace("\n", '', run("readlink {deploy_path}/release"));
});

cd('{release_path}') -> workingPath() -> run("readlink {deploy_path}/release") -(cycle)-> workingPath() -> run("readlink {deploy_path}/release").

Basically, it tries to resolve release_path by trying using itself in the process, which ends up generating a loop.

One possible way to fix this might be to make the release_path and current environment variables strings instead, as such:

/**
 * Return release path.
 */
env('release_path', '{deploy_path}/release');

/**
 * Return current release path.
 */
env('current', '{deploy_path}/current');

Basically, any variable that would be used in the working_path is a closure/callable, a run cycle will occur. Thus, a probably better fix would be to resolve directly the path given to cd when it is called. This way, the working_path value is always a string with no environment variable that needs to be resolved.

function cd($path)
{
    env('working_path', env()->parse($path));
}

[antonmedv]

Yes.

22 ôåâð. 2015 ã., â 21:32, tomzx notifications@github.com íàïèñàë(à):

I assume you're getting this error: PHP Fatal error: Maximum function nesting level of '100' reached, aborting!?

—
Reply to this email directly or view it on GitHub.