Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep consistency with deployer executable naming #2011

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Keep consistency with deployer executable naming #2011

merged 1 commit into from
Mar 6, 2020

Conversation

bpolaszek
Copy link
Contributor

Q A
Bug fix? No
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

This minor change guesses the local name of the deployed.phar script (or ./vendor/bin/dep) for using in console output.

Example with a locked deployment:

$ dep deploy 

Deploy locked.                                        
  Execute "dep deploy:unlock dev" to unlock.
$ ./vendor/bin/dep deploy 

Deploy locked.                                        
  Execute "./vendor/bin/dep deploy:unlock dev" to unlock.
$ php vendor/bin/dep deploy 

Deploy locked.                                        
  Execute "php vendor/bin/dep deploy:unlock dev" to unlock.
$ php deployer.phar deploy 

Deploy locked.                                        
  Execute "php deployer.phar deploy:unlock dev" to unlock.
$ ./bin/deployer deploy 

Deploy locked.                                        
  Execute "./bin/deployer deploy:unlock dev" to unlock.

If called script is found in PATH, a basename() is applied to avoid showing full path (like /usr/local/bin/php or /home/user/.composer/vendor/bin/dep, for instance).
This will help people unfamiliar with the tool to just copy/paste suggestions.

@antonmedv antonmedv merged commit a8dabf0 into deployphp:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants