Return $result if getStdError() returns an empty string. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to support applications which return a non-zero exit status but do not output error messages to stderr.
|
Do you know application like that? |
|
Grunt for example. It is not rare for developers to write to stdout instead of stderr and return a non-zero exit status. |
|
I'd say better always display both stdout and stderr when throwing the RuntimeException. |
antonmedv
pushed a commit
that referenced
this pull request
May 4, 2015
…-is-empty Return $result if getStdError() returns an empty string.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to support applications which return a non-zero exit status but do not output error messages to stderr.