Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes composer not using specified {{bin/php}} #2156

Closed
wants to merge 2 commits into from

Conversation

riconeitzel
Copy link
Contributor

Q A
Bug fix? Yes
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

fixes missing {{bin/php}} in vendor task for composer calls.

forces composer calls to use the specified php binary

@antonmedv
Copy link
Member

Please, update change log

@riconeitzel
Copy link
Contributor Author

@antonmedv done :)

@antonmedv antonmedv closed this Sep 4, 2020
@antonmedv antonmedv reopened this Sep 4, 2020
@antonmedv
Copy link
Member

Somehow travis is now working.

@riconeitzel
Copy link
Contributor Author

"did you try to turn it off and on again?" 🤣 it's green 💚

@antonmedv antonmedv closed this Sep 4, 2020
@antonmedv antonmedv reopened this Sep 4, 2020
@loevgaard
Copy link

I think this is wrong. See

deployer/recipe/common.php

Lines 111 to 122 in 8293eb9

set('bin/composer', function () {
if (commandExist('composer')) {
$composer = '{{bin/php}} ' . locateBinaryPath('composer');
}
if (empty($composer)) {
run("cd {{release_path}} && curl -sS https://getcomposer.org/installer | {{bin/php}}");
$composer = '{{bin/php}} {{release_path}}/composer.phar';
}
return $composer;
});

@antonmedv
Copy link
Member

Yes, @loevgaard is right

@antonmedv antonmedv closed this Sep 6, 2020
@riconeitzel
Copy link
Contributor Author

Then there’s another bug. In my environment composer ran into issues without my patch and was used with php instead of my set bin/php call. I can look into it again.

@loevgaard
Copy link

Because you are running v6 probably :)

@riconeitzel
Copy link
Contributor Author

Downloaded it 5 days ago - no version constraint configured. I’ll check it!

@riconeitzel
Copy link
Contributor Author

Hi there …

I finally looked into it again.

I'm using 6.8.0 via composer - latest stable …

deployer/recipe/common.php

Lines 114 to 125 in 4e243a6

set('bin/composer', function () {
if (commandExist('composer')) {
$composer = locateBinaryPath('composer');
}
if (empty($composer)) {
run("cd {{release_path}} && curl -sS https://getcomposer.org/installer | {{bin/php}}");
$composer = '{{bin/php}} {{release_path}}/composer.phar';
}
return $composer;
});

so - the code @loevgaard mentions isn't part of the stable, yet 🤷🏼‍♂️ so in that case the only way is to use the beta … Am I right?

Rico

@loevgaard
Copy link

Or copy the code and overwrite the bin/composer param in your local deploy.php file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants