Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shopware6.php #2158

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Update shopware6.php #2158

merged 2 commits into from
Sep 9, 2020

Conversation

Schrank
Copy link
Contributor

@Schrank Schrank commented Sep 9, 2020

I'm not sure wether this is interesting for your @peterjaap I hacked a script with the horrible table output to install, upgrade and activate all plugins

I'm not sure wether this is interesting for your @peterjaap I hacked a script with the horrible table output to install, upgrade and activate all plugins
made it a static function
@peterjaap
Copy link
Contributor

peterjaap commented Sep 9, 2020

@Schrank I built the exact same thing but my approach was a bit less hacky; I created a PR at the shopware/platform repo that adds a --format=json flag to the plugin:list command.

I then use this to install & activate plugins on deploy, like this;

task('sw:plugin:activate:all', function(){
    task('sw:plugin:refresh');
    $json = run('cd {{release_path}} && bin/console plugin:list --format=json');
    $pluginList = json_decode($json, true);
    foreach ($pluginList as $plugin) {
        run('cd {{release_path}} && bin/console plugin:install --activate ' . $plugin[0]);
    }
});

I hadn't thought of the update command yet, do you really want to automatically update the extension on deploy?

Until it has been merged, I use a composer patch to apply the PR in my project.

So I didn't add it in the recipe yet, since it depends on code that isn't in the core yet.

@Schrank
Copy link
Contributor Author

Schrank commented Sep 9, 2020

Brilliant idea! 🙈

https://issues.shopware.com/issues/NEXT-10723

@peterjaap
Copy link
Contributor

@Schrank Ugh, the dreaded mostly German Shopware Issuetracker :( They should really kill that and just move it to Github, like any mature company.

@Schrank
Copy link
Contributor Author

Schrank commented Sep 9, 2020

Not gonna happen 🤷‍♂️

@antonmedv
Copy link
Member

So this PR ok to merge? Maybe someone would like to join as maintainer for the recipe?

@Schrank
Copy link
Contributor Author

Schrank commented Sep 9, 2020

The solution by @peterjaap doesn't work until the PR is merged, so I think, merging it and cleaning it up, once the PR is merged is a way to go. And I'm happy to join (pretty sure @peterjaap as well 😅 )

@antonmedv
Copy link
Member

Sounds good!

@antonmedv antonmedv merged commit f16e0cb into deployphp:master Sep 9, 2020
@antonmedv
Copy link
Member

antonmedv commented Sep 9, 2020

Let’s chat little about it https://t.me/antonmedv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants