Fix chgrp

[UlrichThomasGabor]

This fixes #2832.

The second commit replaces -H with -L (as the comment says) and adds -L to chmod.
This is currently not actually a problem for me, but the current status looks kind of arbitrary to me? Why is writable_mode=chmod using -L but writable_mode=chgrp is using -H for chgrp and nothing for chmod?

[UlrichThomasGabor]

I just noticed that GNU chmod does not come with -L (at least the version I have here), so removed it there again...

[antonmedv]

Already fixed.

[UlrichThomasGabor]

@antonmedv ehm no, it is not?

deployer/recipe/deploy/writable.php

Line 87 in 06be0ce

run("$sudo chmod g+rwx $dirs");

The $recursive in this line is important and still missing

[antonmedv]

You are right.

[antonmedv]

Will fix it.

[UlrichThomasGabor]

@antonmedv very good!

What is with -L instead of -H here?

deployer/recipe/deploy/writable.php

Line 86 in a616c9e

run("$sudo chgrp -H $recursive {{http_group}} $dirs");

I think this should be -L as well.

If the mode is chmod it is traversing everything:

deployer/recipe/deploy/writable.php

Line 82 in a616c9e

run("$sudo chown -L $recursive $httpUser $dirs");

so why should mode chgrp behave differently?

[antonmedv]

Agree.

[UlrichThomasGabor]

@antonmedv You are just going to do it? Should we reopen the ticket? This PR includes that change, so I don't know what I should do more

[antonmedv]

Yes, will merge it.

[antonmedv]

Can you resolve conflicts?

[UlrichThomasGabor]

@antonmedv done

[antonmedv]

Thanks!