Add password getter system for customize getting password. (#298)

[ZhukV]

1. Add AskPasswordGetter (ask password before connecting)
2. Add CallabackPasswordGetter (gets password with call callbacks, Closures)

For more information, please see #298

[antonmedv]

Cool! 👍
Need more time to test, try to do all on weekend.
Please, take a look at scrutinizer report for your PR: https://scrutinizer-ci.com/g/deployphp/deployer/inspections/a5866db1-224d-46b3-ad6a-e2e3e6f00568

[ZhukV]

Ok. I not see composer.json.

"symfony/console": "~2.6"

And i checks the QuestionHelper class exists for indicate SymfonyConsole of > 2.5 version.

[antonmedv]

Test coverage decreaseв a little bit. If you can keep them on same level, it will be 100% awesome 👍 But if not, nothing terrible, leave it as it is.

PS Where are a lot issue to implement too, if you want take a look at #297.
PPS Soon Deployer Roadmap will be ready.

[Max-Might]

I think PhpSecLib used to ask for password if it was empty, is that correct?

[ZhukV]

@Max-Might Yes, because password prompt before connection (in configuraiton Configuration::getPassword). The this feature will be worked in any 'adapters' for connection.

Example for ask password:

server('production', 'domain.com')
    ->user('user')
    ->password() // <-- Default null (If null, the AskPasswordGetter will be created automatically)
    ->stage('production')
    ->env('deploy_path', '/var/www/domain.com');

[antonmedv]

Cool feature.

[DirtyB]

Will this work for passphrase in identityFile function?

[ZhukV]

@DirtyB, no, but this easy add.

[antonmedv]

Can you implement this too?

[ZhukV]

ok.

[ZhukV]

Adds.

Attention: by default, passphrase - '' (empty string). For use password getter automatically, you must set null for pass phrase.

->identityFile(null, null, null)

P.S. Can set the null value for $passPhrase as default?

[antonmedv]

Thats ok, pass must be ‘’ as default.

[antonmedv]

Nice work. Need same one else too look at the PR before i'll merge it.

[ZhukV]

ping

[antonmedv]

I tested this feature, look good. Guys, please, test this feature too!

[antonmedv]

@ZhukV i'm going to implement event dispatcher in Deployer. Can you rewrite your feature by using dispatcher later?

[ZhukV]

👍 No problem!