update writable deploy recipe to use release_or_current_path #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating this task to use release_or_current_path (from deployphp#2486) will allow the writable task to be used outside of deployment
midweste
pushed a commit
to midweste/deployer
that referenced
this pull request
Jan 27, 2023
* origin/master: (33 commits) Update default cachetool version to 9.0.0 (PHP 8.1 compatible) (deployphp#3462) Update UPGRADE.md (deployphp#3458) update writable deploy recipe to use release_or_current_path (deployphp#3449) Fix PostgreSQL provisioning Fix PostgresDB user creation Show failed tasks for CI-environments (deployphp#3446) Fix NodeJS 12 warning: update EndBug/add-and-commit action (deployphp#3442) Replace unmaintained satackey/push-prebuilt-action by a maintained fork (deployphp#3437) Fix Node.js 12 actions are deprecated (deployphp#3435) Fix set-output command is deprecated and will be disabled soon (deployphp#3436) Add "new version" banners on release Revert "Fixes deployphp#3365 (deployphp#3400)" Make Deployer work with PHP 8.2 (deployphp#3422) Update symfony/console to ^5.4.9 Update symfony/console to ^5.4.9 Test on php 8.2 as well Revert "Composer update" Composer update [automatic] Update docs with bin/docgen Feature/magento2 artifact deployment (deployphp#3317) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating this task to use release_or_current_path (from #2486) will allow the writable task to be used outside of deployment.
This should probably be done for all tasks after the change in #2486 as it will now be expected to work by others using the software and reading #3337, It has also been done for some more tasks in #2604.
For now, I don't wan to touch more parts of the code without knowing if it will break something else. This does it for
writableonly.Bug fix #…?
New feature?
BC breaks?
Tests added?
Docs added?