New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows to change timezone with UTC as a default #357
Allows to change timezone with UTC as a default #357
Conversation
👍 But I think PR's like this should come with a PR for docs as well. |
Once again I agree @gordalina, there are so much changes it's hard to keep track. |
I think using local time should be default and this PR should be merged. But we have to add docs for it. |
@oanhnn using the default timezone would lead to #338 (comment) |
@lucasmichot |
@oanhnn - Isn't that exactly what this PR does? only default timezone is set via env, not via direct php function in deploy.php however IMO timezone shouldn't be in env, rather it should be in settings - after all we want to have ONE timezone across all, not per-environmant timezone, right? |
I think this is solution for now. But we want to be this is common settings which now can not be implemented and will be implemented in Deployer v4. |
Merged. |
This PR aims to be a solution following various comments on #338.
A revert of a760a9f would reintroduce the bug previously explained.
The following PR provides a default timezone to UTC that can be overridden in the deployment script.
This provides thus a consistency between releases name on different servers, as the TZ on this server might all be different.
Also some documentation on http://deployer.org would be necessary.