Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to change timezone with UTC as a default #357

Closed
wants to merge 2 commits into from
Closed

Allows to change timezone with UTC as a default #357

wants to merge 2 commits into from

Conversation

lucasmichot
Copy link
Contributor

This PR aims to be a solution following various comments on #338.

A revert of a760a9f would reintroduce the bug previously explained.

The following PR provides a default timezone to UTC that can be overridden in the deployment script.
This provides thus a consistency between releases name on different servers, as the TZ on this server might all be different.

Also some documentation on http://deployer.org would be necessary.

@gordalina
Copy link
Contributor

👍 But I think PR's like this should come with a PR for docs as well.

@ZeeCoder
Copy link
Contributor

Once again I agree @gordalina, there are so much changes it's hard to keep track.
Documentation should be as up-to-date as possible.

@oanhnn
Copy link
Contributor

oanhnn commented Jun 18, 2015

I think using local time should be default and this PR should be merged. But we have to add docs for it.

@lucasmichot
Copy link
Contributor Author

I think using local time should be default and this PR should be merged. But we have to add docs for it.

@oanhnn using the default timezone would lead to #338 (comment)
It necessary has to be a fixed timezone that all deployment machines use

@oanhnn
Copy link
Contributor

oanhnn commented Jun 18, 2015

@lucasmichot
Yes. i understand it. I mean set default timezone on deploy.php file and using date() function from deployment PC (not deployment server).

@johnny-bit
Copy link
Contributor

@oanhnn - Isn't that exactly what this PR does? only default timezone is set via env, not via direct php function in deploy.php

however IMO timezone shouldn't be in env, rather it should be in settings - after all we want to have ONE timezone across all, not per-environmant timezone, right?

@antonmedv
Copy link
Member

I think this is solution for now. But we want to be this is common settings which now can not be implemented and will be implemented in Deployer v4.

@antonmedv antonmedv closed this Aug 23, 2015
@antonmedv antonmedv reopened this Aug 23, 2015
@antonmedv
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants