Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SshCommand: Fix host selection #3649

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Jul 23, 2023

  • Bug fix #…?
  • New feature?
  • BC breaks?
  • Tests added?
  • Docs added?

@@ -69,7 +69,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
}

if (count($hostsAliases) === 1) {
$host = current($this->deployer->hosts->all());
$host = $this->deployer->hosts->get($hostsAliases[0]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two hosts:

  • host 0: Localhost
  • host 1: remote Host

The Localhost is removed from $hostAliases. But in this line it was chosen anyway.

@antonmedv antonmedv merged commit adbac8d into deployphp:master Jul 23, 2023
9 checks passed
@gharlan gharlan deleted the ssh-command-host branch July 23, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants